Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow configuration in the home directory #899

Merged
merged 13 commits into from
Oct 10, 2023
Merged

allow configuration in the home directory #899

merged 13 commits into from
Oct 10, 2023

Conversation

marshallwhiteorg
Copy link

@marshallwhiteorg marshallwhiteorg commented Sep 27, 2023 •
edited by github-actions bot
Loading

Describe your changes

Issue number

Closes #880

Checklist before requesting a review

📚 Documentation preview 📚: https://jupysql--899.org.readthedocs.build/en/899/

@tonykploomber
Copy link

LMK if it's ready to review

@marshallwhiteorg marshallwhiteorg marked this pull request as ready for review October 3, 2023 06:15
@marshallwhiteorg
Copy link
Author

@tonykploomber It's ready for review

neelasha23
neelasha23 reviewed Oct 3, 2023
View reviewed changes
src/tests/test_config.py Outdated Show resolved Hide resolved
neelasha23
neelasha23 reviewed Oct 3, 2023
View reviewed changes
src/tests/test_config.py Outdated Show resolved Hide resolved
edublancas
edublancas requested changes Oct 3, 2023
View reviewed changes
doc/api/configuration.md Outdated Show resolved Hide resolved
doc/api/configuration.md Outdated Show resolved Hide resolved
src/tests/test_config.py Outdated Show resolved Hide resolved
src/tests/test_config.py Outdated Show resolved Hide resolved
@marshallwhiteorg
Copy link
Author

Okay it's ready for review again

edublancas
edublancas previously approved these changes Oct 9, 2023
View reviewed changes
@edublancas edublancas requested a review from neelasha23 October 9, 2023 22:20
@edublancas
Copy link

lgtm. @neelasha23: can you run some manual tests and check that everything works as documented?

@marshallwhiteorg: some feedback, you can use monkeypatch from pytest as well, you used patch (which is fine), but it's better to stick with monkeypatch since we use that in other tests.

@edublancas edublancas changed the title #880 User-level config allow configuration in the home directory Oct 9, 2023
@neelasha23
Copy link

lgtm overall!

Just one clarification. what about the case where directory contains pyproject.toml file but it doesn't have the header [tool.jupysql.SqlMagic]. Should it look in ~/.jupysql/config? Is this out of scope?

@edublancas @marshallwhiteorg

@edublancas
Copy link

@neelasha23 good observations. I'll merge this now but open an issue so we can tackle it

@edublancas edublancas merged commit c5f27df into ploomber:master Oct 10, 2023
@edublancas edublancas mentioned this pull request Oct 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edublancas edublancas edublancas approved these changes

@idomic idomic Awaiting requested review from idomic

@tonykploomber tonykploomber Awaiting requested review from tonykploomber

@neelasha23 neelasha23 Awaiting requested review from neelasha23 neelasha23 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SqlMagic Config File Locations
4 participants
@marshallwhiteorg @tonykploomber @edublancas @neelasha23